Create MIDI "root complex" abstraction. #3157
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in SynthstromAudible#2934
this logic is mostly identical, just the location the cable is stored changes.
- it should actually send to the correct port now - it will no longer send to devices that can't be sent to
This function should be a noop since the relevant locations call through virtual function calls.
Also introduces an RAII version of the USB lock
This breaks the ability to plug in the USB cable in peripheral mode and have everything automatically link up (connections saved in flash and the active song), but this seems uncommon and should be handled via a `onUSBDeviceAttach` event anyway as it would provide better support when hosting devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically here as an intermediate step for the tinyusb integration, where the guts of all the USB classes will be ripped out and replaced with stuff that calls in to tinyusb.
Draft until #3136 is merged, as this PR builds on that one (only the last 3 commits here are new).