Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rounding in audio engine, fix optimization bug in scheduler #2310

Merged
merged 6 commits into from
Jul 20, 2024

Conversation

m-m-adams
Copy link
Collaborator

Conversion and rounding to size_t in audio engine sometimes resulted in culling a voice due to a falsely high sample count

At O2 GCC sometimes optimized the check for counting a task's stats away since it can only be modified through the indirect function call, mark it volatile to fix it

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Test Results

75 tests  ±0   75 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
13 files   ±0    0 ❌ ±0 

Results for commit 3a22628. ± Comparison against base commit bf7fb5a.

♻️ This comment has been updated with latest results.

@m-m-adams m-m-adams added this pull request to the merge queue Jul 20, 2024
Merged via the queue into community with commit 9a7a623 Jul 20, 2024
6 checks passed
@m-m-adams m-m-adams deleted the bugfix/rounding_counting branch August 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant