Fix scheduler perf dropping after 128 seconds #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results75 tests 75 ✅ 0s ⏱️ Results for commit e72704e. ♻️ This comment has been updated with latest results. |
m-m-adams
reviewed
Jul 18, 2024
| @@ -386,6 +387,9 @@ void TaskManager::start(double duration) { | |||
| if (duration != 0) { | |||
| mustEndBefore = startTime + duration; | |||
| } | |||
| else { | |||
| mustEndBefore = -1; | |||
There was a problem hiding this comment.
Can we just set this in the constructor? There's no reason to initialize it to 128 anymore, it was a holdover from before the clock rolled properly
There was a problem hiding this comment.
I thought it was weird to ignore the duration parameter if it is zero, it will not work if you call start() first with a timeout and later without a timeout.
Currently, there is a massive increase in scheduler overhead happening after roughly 128 seconds after boot up. As an example, here is scheduler stats before and after when the deluge is idle in an empty song: Before (typical numbers): task_scheduler.cpp:451: Dumping task manager stats: (min/ average/ max) task_scheduler.cpp:470: Load: 84.20 Average Duration: 13.628 Times Called: 340283, Task: audio routine task_scheduler.cpp:470: Load: 1.59 Average Duration: 5.730 Times Called: 19062, Task: read encoders ...... task_scheduler.cpp:478: Working time: 55.94, Overhead: 44.20. Total running time: 120.00 seconds After (typical numbers): task_scheduler.cpp:451: Dumping task manager stats: (min/ average/ max) task_scheduler.cpp:470: Load: 58.62 Average Duration: 33.665 Times Called: 18188, Task: audio routine task_scheduler.cpp:470: Load: 4.59 Average Duration: 4.393 Times Called: 9922, Task: read encoders .... task_scheduler.cpp:478: Working time: 10.06, Overhead: 89.94. Total running time: 140.00 seconds After chasing a few false ends (I was convinced it was a rollover related bug, as rolltime is 128.86 seconds), there is a bug in chooseBestTask() as the deadline is not being setup anymore, which leads to the default value of `double mustEndBefore = 128;` being unchanged. after this, most logic in chooseBestTask stops working as intended. To fix it, add a proper check for running the scheduler without deadline.
Merged
via the queue into
SynthstromAudible:community
with commit Jul 18, 2024
91f5c69
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a massive increase in scheduler overhead happening after roughly 128 seconds after boot up. As an example, here is scheduler stats before and after when the deluge is idle in an empty song:
After chasing a few false ends (I was convinced it was a rollover related bug, as rolltime is 128.86 seconds), there is a bug in chooseBestTask() as the deadline is not being setup anymore, which leads to the default value of
double mustEndBefore = 128;being unchanged. after this, most logic in chooseBestTask stops working as intended.To fix it, add a proper check for running the scheduler without deadline.