Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip Names #2293

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Clip Names #2293

merged 5 commits into from
Jul 27, 2024

Conversation

KrisGelero
Copy link
Contributor

Clip Names support for the Deluge

  • Name KIT & Synth Clips to select their names on the arrangement or grid view.
  • Drum KIT can be set for clip name (affect entire) or per note row changing the name of sample loaded.
  • Auto clip name for AUDIO Clips. (extract the filepath of the selected sample).

Tried to make the codebase as small as possible and tested with different scenarios. It's my first C++, please let me know if there are errors, so I can learn from it.

Many thanks!

Copy link
Contributor

github-actions bot commented Jul 14, 2024

Test Results

75 tests  +5   75 ✅ +5   0s ⏱️ ±0s
13 suites +2    0 💤 ±0 
13 files   +2    0 ❌ ±0 

Results for commit 212ccc1. ± Comparison against base commit 0f7cee3.

♻️ This comment has been updated with latest results.

@KrisGelero
Copy link
Contributor Author

The code has a serious bug that I need to resolve :) Will dive into it.

@m-m-adams m-m-adams marked this pull request as draft July 16, 2024 19:31
@KrisGelero KrisGelero marked this pull request as ready for review July 17, 2024 15:18

if (output->type == OutputType::AUDIO) {
AudioClip* audioclip = (AudioClip*)clip;
clip->clipName.set(&audioclip->sampleHolder.filePath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be handled by the view, it should be set when the audio clip's file path is set or recording is finalized

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to change this part and look where the entry point is ( maybe on a few different places )

src/deluge/gui/views/arranger_view.cpp Show resolved Hide resolved
}
}
// if else then just keep it like the old way to rename the kit row item
goto doNextAfterName;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in-extensible (nobody can add another condition to the if else chain without breaking the goto)

Could you put all the conditions into the if statement? Split this block out to a function that returns true if the editing took place and false otherwise so it continues down the chain. Then just return dealt with if the condition is met

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see why audio clips are excluded

Copy link
Contributor Author

@KrisGelero KrisGelero Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, was a bit of a dirty patch here with the label. Will wrap it in a function.

@m-m-adams m-m-adams added this pull request to the merge queue Jul 27, 2024
Merged via the queue into SynthstromAudible:community with commit 706a1e5 Jul 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants