-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Feature: Add Automated Stem Exporting for Kit Rows #2285
Closed
seangoodvibes
wants to merge
7
commits into
SynthstromAudible:community
from
seangoodvibes:Stem-Export-for-Kit-Rows
Closed
[DRAFT] Feature: Add Automated Stem Exporting for Kit Rows #2285
seangoodvibes
wants to merge
7
commits into
SynthstromAudible:community
from
seangoodvibes:Stem-Export-for-Kit-Rows
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seangoodvibes
force-pushed
the
Stem-Export-for-Kit-Rows
branch
3 times, most recently
from
July 12, 2024 01:37
ebe877f
to
b2cd4f8
Compare
seangoodvibes
force-pushed
the
Stem-Export-for-Kit-Rows
branch
from
July 19, 2024 19:54
aabd20f
to
3e2a3b0
Compare
seangoodvibes
changed the title
Feature: Add Automated Stem Exporting for Kit Rows
[DRAFT] Feature: Add Automated Stem Exporting for Kit Rows
Jul 20, 2024
Added Stem Export for Kit Rows using the same shortcut as in Song and Arranger (Hold Save + Press Record) Exports each kit row individually. Muted kit rows and kit rows with no notes in them are excluded from the export. Stems are labelled as a "Drum" and include the Drum Name. Updated documentation
Update render of kit rows to exclude all Kit Affect Entire FX except for the Pitch Adjustment
Added check to only exclude kit affect entire FX from stem export if you are exporting drum stems
Added [[unlikely]] tag to mark happy path
- Stems are now exported until the end of the sequence and until silence is reached - Updated progress display to show the # of stems exported out of the # of stems that will be exported - Stem export for clips and kit rows now takes into account the length of the sequence (so for a clip it will export until the length of the longest note row is reached and for kit rows it will export until the length of that kit row is reached)
seangoodvibes
force-pushed
the
Stem-Export-for-Kit-Rows
branch
from
July 23, 2024 05:22
0ced02c
to
df5ad38
Compare
seangoodvibes
changed the title
[DRAFT] Feature: Add Automated Stem Exporting for Kit Rows
Feature: Add Automated Stem Exporting for Kit Rows
Jul 23, 2024
seangoodvibes
changed the title
Feature: Add Automated Stem Exporting for Kit Rows
[DRAFT] Feature: Add Automated Stem Exporting for Kit Rows
Jul 23, 2024
seangoodvibes
added
the
deferred
for PR's that are taking longer / not progressing
label
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated Stem Export for Kit Rows
IMG_9847.mov
Description
Added Stem Export for Kit Rows using the same shortcut as in Song and Arranger (Hold Save + Press Record)
Exports each kit row individually without Kit Affect Entire FX applied (except for the Kit Affect Entire Pitch Adjustment which is still applied)
Muted kit rows, kit rows with no notes, and kit rows that are MIDI or CV drums are excluded from the export.
Stems are labelled as a "Drum" and include the Drum Name.