Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Feature: Add Automated Stem Exporting for Kit Rows #2285

Conversation

seangoodvibes
Copy link
Collaborator

@seangoodvibes seangoodvibes commented Jul 12, 2024

Automated Stem Export for Kit Rows

Screenshot 2024-07-11 at 9 00 16 PM
IMG_9847.mov

Description

Added Stem Export for Kit Rows using the same shortcut as in Song and Arranger (Hold Save + Press Record)

Exports each kit row individually without Kit Affect Entire FX applied (except for the Kit Affect Entire Pitch Adjustment which is still applied)

Muted kit rows, kit rows with no notes, and kit rows that are MIDI or CV drums are excluded from the export.

Stems are labelled as a "Drum" and include the Drum Name.

@seangoodvibes seangoodvibes marked this pull request as draft July 12, 2024 00:56
Copy link
Contributor

github-actions bot commented Jul 12, 2024

Test Results

75 tests  ±0   75 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
13 files   ±0    0 ❌ ±0 

Results for commit c9627b4. ± Comparison against base commit 9a7a623.

♻️ This comment has been updated with latest results.

@seangoodvibes seangoodvibes force-pushed the Stem-Export-for-Kit-Rows branch 3 times, most recently from ebe877f to b2cd4f8 Compare July 12, 2024 01:37
@seangoodvibes seangoodvibes marked this pull request as ready for review July 13, 2024 04:22
@seangoodvibes seangoodvibes marked this pull request as draft July 14, 2024 03:22
@seangoodvibes seangoodvibes marked this pull request as ready for review July 14, 2024 05:38
@seangoodvibes seangoodvibes force-pushed the Stem-Export-for-Kit-Rows branch from aabd20f to 3e2a3b0 Compare July 19, 2024 19:54
@seangoodvibes seangoodvibes marked this pull request as draft July 20, 2024 20:14
@seangoodvibes seangoodvibes changed the title Feature: Add Automated Stem Exporting for Kit Rows [DRAFT] Feature: Add Automated Stem Exporting for Kit Rows Jul 20, 2024
Added Stem Export for Kit Rows using the same shortcut as in Song and Arranger (Hold Save + Press Record)

Exports each kit row individually.

Muted kit rows and kit rows with no notes in them are excluded from the export.

Stems are labelled as a "Drum" and include the Drum Name.

Updated documentation
Update render of kit rows to exclude all Kit Affect Entire FX except for the Pitch Adjustment
Added check to only exclude kit affect entire FX from stem export if you are exporting drum stems
Added [[unlikely]] tag to mark happy path
- Stems are now exported until the end of the sequence and until silence is reached
- Updated progress display to show the # of stems exported out of the # of stems that will be exported
- Stem export for clips and kit rows now takes into account the length of the sequence (so for a clip it will export until the length of the longest note row is reached and for kit rows it will export until the length of that kit row is reached)
@seangoodvibes seangoodvibes force-pushed the Stem-Export-for-Kit-Rows branch from 0ced02c to df5ad38 Compare July 23, 2024 05:22
@seangoodvibes seangoodvibes changed the title [DRAFT] Feature: Add Automated Stem Exporting for Kit Rows Feature: Add Automated Stem Exporting for Kit Rows Jul 23, 2024
@seangoodvibes seangoodvibes marked this pull request as ready for review July 23, 2024 05:30
@seangoodvibes seangoodvibes marked this pull request as draft July 23, 2024 05:41
@seangoodvibes seangoodvibes changed the title Feature: Add Automated Stem Exporting for Kit Rows [DRAFT] Feature: Add Automated Stem Exporting for Kit Rows Jul 23, 2024
@seangoodvibes seangoodvibes added the deferred for PR's that are taking longer / not progressing label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred for PR's that are taking longer / not progressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant