sidebar: session macros in keyboard #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfredl
force-pushed
the
session_macros
branch
5 times, most recently
from
bf19703 to
c6d286a
Compare
bfredl
force-pushed
the
session_macros
branch
2 times, most recently
from
0978fba to
664b48e
Compare
bfredl
force-pushed
the
session_macros
branch
3 times, most recently
from
b676a02 to
3b9c9bc
Compare
bfredl
changed the title
|
Ready for review. UI design: need a button combination for jumping to editing clip instead of launching. I picked AFFECT ENTIRE because it currently has no "latching" behavior in clips (it is always lit) and thus is safe as a modifier, and AFFECT+SONG is an ok combo for the left hand while picking the macro with the right hand. Other suggestions welcome. |
m-m-adams
reviewed
Aug 6, 2024
|
thanks, updated |
|
Hi, I opened an issue as a follow-up to this PR as I don't want to hold off merging this. Mostly just some UI consistency changes that I want to make. |
m-m-adams
approved these changes
Aug 9, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Aug 9, 2024
aa4175b
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my major workflow issues with the deluge has been, that while jamming on the keyboard on a part, jumping to song view and back to change some background part is just too many keypresses to switch to session view, press the right button which just wasn't visible until now and then jump back in to the correct keyboard part again, and now the "flow" of the jam is already lost.
Add a sidebar where the song parts can be controlled directly from the keyboard screen. This is done as 8 configurable "macros" which in this draft can be one of
Suggestions for more behaviors welcome. Like I considered expanding the first option to layer any set of part in an arbitrary combination (not just sections), but wanted to start with something simple.
Very early draft, some missing pieces: