[DRAFT] Refactor Audio file system #1277
Draft
+384
−316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seangoodvibes
changed the title
stellar-aria
force-pushed
the
refactor-audio-file
branch
from
50b9fc8 to
547b62b
Compare
stellar-aria
force-pushed
the
refactor-audio-file
branch
from
93cad58 to
debe95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for refactoring the Audio File system. If/when this is merged, I'm strongly recommending that this be done as a merge commit to preserve history for bisect
The goal will be to extract all AudioFile loading logic from the Sample/Wavetable class hierarchy and change them to a has a rather than an is a (composition over inheritance) so that Samples and WaveTables can be said to have associated FileHandlers but are not actually [Audio]Files themselves.
Doing this properly will also allow us to create unit tests for our file loading/parsing logic, since decoupling from Samples/Wavetables they should only handle their own local object creation
So far: