BFP config, wstETH and sUSDe as collaterals on L1 #468
Conversation
0xMithrandir
commented
Oct 7, 2024
•
0xMithrandir
commented
- Configures wstETH and sUSDe as collaterals
- Updates BFP package to 3.8.0
0xMithrandir
changed the title
0xMithrandir
changed the title
0xMithrandir
changed the title
# Conflicts: # omnibus-mainnet.toml
0xMithrandir
changed the title
| assert.equal(newPosition.positionSize, 0); | ||
| }); | ||
|
|
||
| it('should mint and withdraw 1000 sUSD', async () => { |
There was a problem hiding this comment.
I don't think we need any of these tests (borrow/withdraw) for CoreProxy. Why would we need them (given we have separate Liquidity_Provider test)?
There was a problem hiding this comment.
It's mostly to test calculation and payback of debt in the next test
| @@ -0,0 +1,387 @@ | |||
| const crypto = require('crypto'); | |||
There was a problem hiding this comment.
file can be named sUSD instead of snxUSD
tomls/omnibus-mainnet/bfp.toml
Outdated
| "<%= settings.weth_rewards_distributor %>", | ||
| ] | ||
|
|
||
| #[invoke.CoreProxy_registerRewardsDistributor_wsteth] |
| issuanceRatioD18 = "<%= parseEther('5') %>" | ||
| liquidationRatioD18 = "<%= parseEther('1.05') %>" | ||
| liquidationRewardD18 = "<%= settings.snx_liquidation_reward %>" | ||
| minDelegationD18 = "<%= 2 * settings.snx_liquidation_reward %>" |
There was a problem hiding this comment.
we probably want smth like 100 here at least
There was a problem hiding this comment.
and use snx_min_delegation setting
| issuanceRatioD18 = "<%= parseEther('2') %>" | ||
| liquidationRatioD18 = "<%= parseEther('1.10') %>" | ||
| liquidationRewardD18 = "<%= parseEther('0.005') %>" | ||
| minDelegationD18 = "<%= parseEther('0.01') %>" |
There was a problem hiding this comment.
can we normalise all configs and have settings for susde? I can see 3 new collaterals and each has somewhat different implementation. Would be easier if they all follow exact structure
