This repository has been archived by the owner on Sep 19, 2022. It is now read-only.
Feature/background #1277
Open
Feature/background #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noisekit
reviewed
Sep 1, 2022
sections/shared/Layout/AppLayout.tsx
Outdated
| `} | ||
| ${({ stakingV2Enabled }) => media.greaterThan('mdUp')` | ||
| padding-left: ${ | ||
| stakingV2Enabled ? '0px' : `calc(${DESKTOP_SIDE_NAV_WIDTH + DESKTOP_BODY_PADDING}px)` |
There was a problem hiding this comment.
Can we use const STAKING_V2_ENABLED directly here?
If we only use const as is everywhere it will be easy to find and remove it later, comparing to cleaning up extra custom props.
There was a problem hiding this comment.
From the perspective of searching for it? Makes sense.
There was a problem hiding this comment.
I meant if this env var is globally available we don't need custom props at all.
this is def a nice improvement for easy search for sure!
0xjocke
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS Repeat pattern