Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Alert component #1245

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Alert component #1245

wants to merge 4 commits into from

Conversation

fritzschoff
Copy link
Contributor

No description provided.

@fritzschoff fritzschoff requested a review from a team August 22, 2022 14:32
@vercel
Copy link

vercel bot commented Aug 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
staking ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 6:45AM (UTC)

min-width: 170px;
border: 1px solid black;
cursor: pointer;
`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as on the last PR, lets figure out how to style this without styled components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it in the last PR. Will be resolved here as well when merged. This branch is branched off the other one.

@fritzschoff
Copy link
Contributor Author

fritzschoff commented Aug 23, 2022

Bildschirmfoto 2022-08-23 um 08 37 56

import { InfoIcon } from '@chakra-ui/icons';
import { Container, Fade, Text } from '@chakra-ui/react';

interface AlterProps {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

text: string;
}

export default function Alert({ text }: AlterProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this. Looking at this design here, it looks like we have primary, secondary, tertiary variants and success, info, warning and error states.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also haven't had a convo with @bachstatter or @noisekit about it, but it would be good by default if we have the option to pass a style object to all our primitives

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't knew that this file existed! I was doing the component based of the burn flow in a different file. Well there is plenty to add here. Will do, thanks!

@fritzschoff fritzschoff marked this pull request as draft August 23, 2022 14:48
Base automatically changed from refresh to dev August 29, 2022 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants