-
Notifications
You must be signed in to change notification settings - Fork 75
Alert component #1245
base: dev
Are you sure you want to change the base?
Alert component #1245
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
min-width: 170px; | ||
border: 1px solid black; | ||
cursor: pointer; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as on the last PR, lets figure out how to style this without styled components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it in the last PR. Will be resolved here as well when merged. This branch is branched off the other one.
components/Alert/index.tsx
Outdated
import { InfoIcon } from '@chakra-ui/icons'; | ||
import { Container, Fade, Text } from '@chakra-ui/react'; | ||
|
||
interface AlterProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks
components/Alert/index.tsx
Outdated
text: string; | ||
} | ||
|
||
export default function Alert({ text }: AlterProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start on this. Looking at this design here, it looks like we have primary, secondary, tertiary variants and success, info, warning and error states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also haven't had a convo with @bachstatter or @noisekit about it, but it would be good by default if we have the option to pass a style object to all our primitives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didn't knew that this file existed! I was doing the component based of the burn flow in a different file. Well there is plenty to add here. Will do, thanks!
No description provided.