expose mask functions for PET scatter estimation #1280
Conversation
|
Hi Kris, I got the following error when I tried to build from this branch, with STIR-master: I think the problem is that "set_recompute_mask_image" of the stir::ScatterEstimation is not exposed to the sirf::PETScatterEstimator in src/xSTIR/cSTIR/include/sirf/STIR/stir_x.h, as the other newly accessed methods are here: I think I managed to fix it, PR is here: KrisThielemans#2 |
if STIR is recent enough
…ugfix expose stir-method set_recompute_mask_image to cSTIR
…IRF-object ScatterEstimator
|
@NicoleJurjew this is now working fine (or at least, compiling!) on the C++ level. Time for @evgueni-ovtchinnikov to wrap these to Python? |
|
@KrisThielemans I'm a bit confused. I thought I'd exposed this to Python in a PR to your fork, here: I don't really know what to do now, do I merge master into my PR and hope it all works automatically? |
…ugfix Expose mask methods for scatter to Python
|
oops. I forgot. merged now. I'll add something to CHANGES.md later. |
|
I meant, I've merged your PR to my branch. Not yet this PR! |
[ci skip]
|
@NicoleJurjew you can now use |
|
Thank you!
…________________________________
From: Kris Thielemans ***@***.***>
Sent: 22 November 2024 14:53
To: SyneRBI/SIRF ***@***.***>
Cc: Jurjew, Nicole ***@***.***>; Mention ***@***.***>
Subject: Re: [SyneRBI/SIRF] expose mask functions for PET scatter estimation (PR #1280)
⚠ Caution: External sender
@NicoleJurjew<https://github.com/NicoleJurjew> you can now use master (after pulling)
—
Reply to this email directly, view it on GitHub<#1280 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUSFUBRSZE47QM5JYU464ED2B5APTAVCNFSM6AAAAABKV3C5MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJTHE2DCNBWGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@NicoleJurjew, this is now a PR. You can do a PR to my branch to fix/add.