Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

915494: Resolved dependent bot issues in customize toolbar and open close bookmark sample #30

Merged
1 commit merged into from
Oct 18, 2024

Conversation

Dharshana4609
Copy link
Collaborator

Bug description

Resolve the Dependent bot issues for EJ2 PDFViewer

Root cause

Need to upgrade to vue3

Solution description

Checked and updated to vue3

Reason for not identifying earlier

  • Guidelines not followed. If yes, provide which guideline is not followed.

  • Guidelines not given. If yes, provide which/who need to address.
    Tag label update-guideline-coreteam or update-guideline-productteam.

  • If any other reason, provide the details here.

Areas tested against this fix

Provide details about the areas or combinations that have been tested against this code changes.

Is it a breaking issue?

  • Yes, Tag breaking-issue.
  • NO

If yes, provide the breaking commit details / MR here.

Action taken

What action did you take to avoid this in future?

Feature matrix document updated

  • Yes
  • NO
  • NA

Automation details - Mark Is Automated field as (Yes, Manual, Not Applicable) in corresponding JIRA task once the bug is automated.

  • BUnit, share corresponding MR.
  • E2E or Manual Automation using tester - Make sure all items are automated with priority before release which can be tracked in automation dashboard.

If the same issue is reproduced in ej2, what will you do?

  • Resolved. Provide MR link.
  • NO. Created task to track it. Share task link.
  • NA

Is this common issue need to be addressed in the same component or on other components in our platform?

  • Yes - Need to check in other components, tag needs-attention-coreteam
  • No

Output screenshots

Before Fix:

After Fix:

Blazor Checklist

Confirm whether this feature is ensured in both Blazor Server and WASM

  • NA
  • Yes
  • NO

Is there any new API or existing API name change?

  • Yes. If yes, Provide API Review task link.
  • NO

Is there any existing behavior change due to this code change?

  • Yes. Add breaking-change label.
  • NO

Do the code changes cause any memory leak and performance issue? (Test only if you suspect that your code may cause problem)

  • Yes
  • NO

Reviewer Checklist

  • All provided information are reviewed and ensured.

@ghost ghost merged commit 41eb465 into master Oct 18, 2024
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant