Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: default values for lon and lat in df_geojson. #92

Closed
wants to merge 2 commits into from
Closed

Minor: default values for lon and lat in df_geojson. #92

wants to merge 2 commits into from

Conversation

layik
Copy link

@layik layik commented Dec 9, 2021

Minor cont. to add characters "lon" and "lat" as default values for function df_geojson.

It is meant to save new users learning about providing column names, and it should kick-start thinking about detecting column names via grep in future.

Could even add z = elevation.

Not quite sure why devtools::document() made some changes to a .cpp file so happy to "reset" that.

@dcooley
Copy link
Collaborator

dcooley commented Dec 9, 2021

Thanks for the suggestion.

detecting column names via grep in the future.

Given this, it's probably worth copying what I do in mapdeck here - where I auto-detect the lon & lat columns.

@layik layik closed this by deleting the head repository Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants