Make handle_dates ignore geometry column #33
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out the development version (because of the fix for Dates/POSIXt), and noticed that it was much slower than the version on CRAN:
The difference was even more pronounced in the larger object I was working with.
Because the geometry column in sf objects is "sticky",
x[dte]
in thelapply
inhandle_dates()
will always include the geometry column, meaning that it will get converted to character (super slow). Converting x to a regulardata.frame
means only the columns matched bydte
will get converted.