-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis Support for FedScale #170
base: master
Are you sure you want to change the base?
Conversation
…or on local machine
docker/driver.py
Outdated
@@ -143,6 +145,12 @@ def terminate(job_name): | |||
print_help: bool = False | |||
if len(sys.argv) > 1: | |||
if sys.argv[1] == 'submit' or sys.argv[1] == 'start': | |||
redis_exec = '/usr/bin/redis-server' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the hardcoded path? Instead, use some like os.environ["REDIS_PATH"]
@@ -6,6 +6,7 @@ dependencies: | |||
- tensorboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember you mentioned that some tf version is not compatible. Can you please update tf version here too?
@@ -32,6 +34,13 @@ def __init__(self, args): | |||
self.device = args.cuda_device if args.use_cuda else torch.device( | |||
'cpu') | |||
|
|||
# ======== redis client ======== | |||
# <host, port, ...> should be specified in args | |||
host = "127.0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove any hard code in the future, using args.xxx instead.
Thanks a lot for your contribution! Let's try to run an e2e evaluation to validate the learning curve and Redis overhead first. |
… start and client init logic
Thanks for your contribution. Can you please
We really appreciate your help. |
Why are these changes needed?
To integrate Redis into aggregator for saving aggregation data.
Related issue number
N/A
Checks
Note: