Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): get image repository host on login #3377

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

olevski
Copy link
Member

@olevski olevski commented Mar 23, 2023

closes #3301

Should be merged only after SwissDataScienceCenter/renku-gateway#636 is merged and a new version of the gateway is released.

@coveralls
Copy link
Collaborator

coveralls commented Mar 24, 2023

Pull Request Test Coverage Report for Build 4510044419

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+85.9%) to 85.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/login.py 6 8 75.0%
Totals Coverage Status
Change from base Build 4480159119: 85.9%
Covered Lines: 25623
Relevant Lines: 29826

💛 - Coveralls

Panaetius
Panaetius previously approved these changes Mar 24, 2023
@olevski olevski force-pushed the 3301-get-image-registry-host-on-login branch from c53bd56 to 0fbd394 Compare March 24, 2023 10:06
@olevski olevski force-pushed the 3301-get-image-registry-host-on-login branch from 0fbd394 to f7fc673 Compare March 24, 2023 10:09
@Panaetius
Copy link
Member

we should get this merged at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Get actual gitlab/registry URLs from the gateway on renku login
3 participants