-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(load-test): Add load test for classroom scenario #3203
Conversation
This PR adds a load test that simulates a starting class: 1. Login 2. Fork an example project 3. Start session 4. Wait for session to start 5. Let session run for n seconds 6 Shutdown session 7. Cleanup/delete forked project Additionally a custom metric + trend is introduced which measures the servers startup time. I was running into some problems, where I was getting 401 errors forking the project, even after successfull login. This has not been resolved yet.
@li-il-li can you move this over to the notebooks repo? I think it targets pretty much exclusively renku-notebooks components. EDIT: Actually nvm. I see that this way you can reuse the login function. If you move this then we would have to copy things over. So it is all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing about the retries. I think they are valuable insights (i.e. bugs) from the load testing. We should fail the load tests if API requests need to be retried.
Ok lets just get this in because the added tests are definitely useful. I opened an issue to look a bit more into why some requests need retries: #3240 |
This PR adds a load test that simulates a starting class:
Additionally a custom metric + trend is introduced which measures the servers
startup time.
I was running into some problems, where I was getting 401
errors forking the project, even after successfull login.
This has not been resolved yet.