Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds lazy loading to deserialization #18

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Conversation

Panaetius
Copy link
Member

Enables lazy loading

Closes #12

Only executes deserialization code when a property of a nested class is accessed.

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, a few minor comments.

calamus/fields.py Outdated Show resolved Hide resolved
calamus/fields.py Outdated Show resolved Hide resolved
tests/test_deserialization.py Outdated Show resolved Hide resolved
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, Thanks!

@Panaetius Panaetius merged commit 1c79709 into master Jun 30, 2020
@Panaetius Panaetius deleted the 12-lazy-loading branch June 30, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lazy loading via proxy objects
2 participants