-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swinject storyboard ability to pass arguments to vc #112
Open
aayers-agrible
wants to merge
25
commits into
Swinject:master
Choose a base branch
from
aayers-agrible:feature/swinject-storyboard-ability-to-pass-arguments-to-vc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/swinject storyboard ability to pass arguments to vc #112
aayers-agrible
wants to merge
25
commits into
Swinject:master
from
aayers-agrible:feature/swinject-storyboard-ability-to-pass-arguments-to-vc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toryboard # Conflicts: # Cartfile
…s-arguments-to-vc
…o-vc' of github.com:aayers-agrible/SwinjectStoryboard into feature/swinject-storyboard-ability-to-pass-arguments-to-vc
@jakubvano, can you take a look at this PR and see if it seems reasonable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the branch from #62. If there's a better way to add commits to that fork rather than to open a new PR, please let me know and I'll close this and do whatever.
This takes the work started in that PR and addresses the feedback given by the maintainers.
Added code generation and tests for adding arguments to instantiateViewController methods.