Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using array of tuples instead of Dictionary for errors and validators. #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions Validator/Validator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,18 @@
import Foundation
import UIKit

@objc public protocol ValidationDelegate {
public typealias ValidatorErrors = [(field: UITextField, error: ValidationError)]
public typealias ValidatorRules = [(field: UITextField, rule: ValidationRule)]

public protocol ValidationDelegate {
func validationSuccessful()
func validationFailed(errors: [UITextField:ValidationError])
func validationFailed(errors: ValidatorErrors)
}

public class Validator {
// dictionary to handle complex view hierarchies like dynamic tableview cells
public var errors = [UITextField:ValidationError]()
public var validations = [UITextField:ValidationRule]()
public var errors: ValidatorErrors = []
public var validations: ValidatorRules = []
private var successStyleTransform:((validationRule:ValidationRule)->Void)?
private var errorStyleTransform:((validationError:ValidationError)->Void)?

Expand All @@ -26,12 +29,11 @@ public class Validator {
// MARK: Private functions

private func validateAllFields() {

errors = [:]
errors.removeAll()

for (textField, rule) in validations {
if var error = rule.validateField() {
errors[textField] = error
if let error: ValidationError = rule.validateField() {
errors.append(field: textField, error: error)

// let the user transform the field if they want
if let transform = self.errorStyleTransform {
Expand All @@ -55,20 +57,24 @@ public class Validator {
}

public func registerField(textField:UITextField, rules:[Rule]) {
validations[textField] = ValidationRule(textField: textField, rules: rules, errorLabel: nil)
validations.append(field: textField, rule: ValidationRule(textField: textField, rules: rules, errorLabel: nil))
}

public func registerField(textField:UITextField, errorLabel:UILabel, rules:[Rule]) {
validations[textField] = ValidationRule(textField: textField, rules:rules, errorLabel:errorLabel)
validations.append(field: textField, rule:ValidationRule(textField: textField, rules:rules, errorLabel:errorLabel))
}

public func unregisterField(textField:UITextField) {
validations.removeValueForKey(textField)
errors.removeValueForKey(textField)
if let validationIndex = validations.find({ $0.0 == textField}) {
validations.removeAtIndex(validationIndex)
}

if let errorIndex = errors.find({ $0.0 == textField}) {
validations.removeAtIndex(errorIndex)
}
}

public func validate(delegate:ValidationDelegate) {

self.validateAllFields()

if errors.isEmpty {
Expand All @@ -78,10 +84,20 @@ public class Validator {
}
}

public func validate(callback:(errors:[UITextField:ValidationError])->Void) -> Void {

public func validate(callback:(errors:ValidatorErrors)->Void) -> Void {
self.validateAllFields()

callback(errors: errors)
}
}

private extension Array {
func find(includedElement: T -> Bool) -> Int? {
for (idx, element) in enumerate(self) {
if includedElement(element) {
return idx
}
}
return nil
}
}
4 changes: 2 additions & 2 deletions Validator/ViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import Foundation
import UIKit


class ViewController: UIViewController , ValidationDelegate, UITextFieldDelegate {
class ViewController: UIViewController, ValidationDelegate, UITextFieldDelegate {

// TextFields
@IBOutlet weak var fullNameTextField: UITextField!
Expand Down Expand Up @@ -71,7 +71,7 @@ class ViewController: UIViewController , ValidationDelegate, UITextFieldDelegate
self.presentViewController(alert, animated: true, completion: nil)

}
func validationFailed(errors:[UITextField:ValidationError]) {
func validationFailed(errors:ValidatorErrors) {
println("Validation FAILED!")
}

Expand Down