[#1176] PDF Page Orientation based on Image Detection #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NA - Resolving Issues Involving Dependencies
…matic detection). Probably needs refactoring or extra checks in case I have messed anything up.
|
Code Climate has analyzed commit 79a28d3 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature allows users to have a portrait or landscape page depending on the dimensions of their image. This allows images to be much more visible with less whitespace surrounding it.
An example PDF using a portrait, landscape and square image without this feature:
The same PDF with the same images with this feature:
Dependencies were also changed to different sources and versions so that the project can run on any Android Studio import. This can be reverted if there have been changes made to this, or perhaps something just happened to go wrong when I tried importing this project myself.
Implements #1176
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleI also had other people in my team (collaborators on the fork this branch has come from) test this implementation by running the application on their own devices.
Checklist: