feat: use async node-hid #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nel.
This is because previously we used a hack where we used .devicePath for these. This property (as far as I can tell) doesn't exist anymore, so we should not support it.
As a backwards compatibility, a blind implementation for supporting { devicePath: string } was added.
nytamin
approved these changes
Dec 4, 2023
Comment on lines
+21
to
+23
| this.device.write(data).catch((err) => { | ||
| this.emit('error', err) | ||
| }) |
There was a problem hiding this comment.
Just a question: Is it ok to write like this? ie we don't have to worry about concurrency or add some promise queue here?
There was a problem hiding this comment.
Hmm actually yeah, this does need to be put in a queue.
close might need to be put in the same queue too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the library to node-hid v3.0.0. This switches to using the async version of node-hid, which avoids the limitation of only being able to use 4 devices and increases usb performance by moving the blocking usb ui off of the nodejs main thread.