Add flush() method #115
Merged
Add flush() method #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @loucadufault, could you give this PR a quick review to ensure that it fits with your use case (pay extra attention to the unit tests) ? |
loucadufault
approved these changes
Dec 5, 2024
Comment on lines
+25
to
+27
| .add(async () => { | ||
| await this.device.write(data) | ||
| }) |
There was a problem hiding this comment.
small nit: you could directly return the promise here
Suggested change
| .add(async () => { | |
| await this.device.write(data) | |
| }) | |
| .add(() => this.device.write(data)) |
Comment on lines
+168
to
+169
| expect(mockWriteEnd).toBeCalledTimes(0) // Should not have been called yet | ||
|
|
There was a problem hiding this comment.
you could use jest fake timers instead, and advance the timers here by 10ms to make the test a bit more guaranteed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
flush()method, as discussed in #106