fix: remove casparcg-template media support for transitions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is is not supported by casparCG nor the code in this repo anyway
|
Why not change the type of the TemplateLayerBase instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix, bad typings.
What is the current behavior? (You can also link to an open issue here)
Types say that the TEMPLATE
media: string | TransitionObject | null. But a transition is actually not supported by CasparCGWhat is the new behavior (if this is a feature change)?
change type to
media: string | nullOther information:
ref: Fix: casparCG template transitions bug nrkno/sofie-timeline-state-resolver#225