Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fix in INFO CHANNEL deserializer #194

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nytamin
Copy link
Member

@nytamin nytamin commented Oct 17, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

Deserializer fails when the element was missing (when there is an empty channel)

  • What is the new behavior (if this is a feature change)?

Deserializer returns layers: [] as expected

  • Other information:

Verified

This commit was signed with the committer’s verified signature.
aanorbel Norbel AMBANUMBEN
deserializer failed when the <stage> element was missing (when there is an empty channel)
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (81757d1) 81.32% compared to head (985417b) 81.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   81.32%   81.35%   +0.02%     
==========================================
  Files          14       14              
  Lines         723      724       +1     
  Branches      164      165       +1     
==========================================
+ Hits          588      589       +1     
  Misses        131      131              
  Partials        4        4              
Files Coverage Δ
src/deserializers/deserializeInfoChannel.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin requested a review from mint-dewit October 17, 2023 06:49
@nytamin nytamin merged commit 1a929da into master Oct 17, 2023
10 checks passed
@nytamin nytamin deleted the fix/bug-deserialize-info-channel branch October 17, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants