refactor: undo/redo #179
Merged
refactor: undo/redo #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
nytamin
approved these changes
Nov 2, 2023
| @@ -129,25 +107,32 @@ type ConvertToServerSide<T> = { | |||
| : T[K] | |||
| } | |||
|
|
|||
| function Undoable(target: EverythingService, _key: string, descriptor: PropertyDescriptor) { | |||
There was a problem hiding this comment.
Should we add a description here explaining that the intended usage is as a decorator?
| const enableArray = Array.isArray(tObj.obj.enable) ? tObj.obj.enable : [tObj.obj.enable] | ||
| for (const enable of enableArray) { | ||
| if (enable.start && typeof enable.start === 'string') { | ||
| // TODO: immer js? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #174,
Makes undo/redo scoped to one of: current rundown, application (home), peripheral devices - depending on which section of the UI is active.
Disables
nodeIntegrationand enablescontextIsolationfor the main Electron app.