fix: make bridge and device initialization more robust #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not include the abort controlled
|
Kudos, SonarCloud Quality Gate passed!
|
nytamin
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on how we handle reconfiguring devices and re-connection of Bridges.
The issue from #64 is definitely less severe. In some rare cases I the list still does not populate immediately, but pressing the "Refresh all resources" button solves it.
This also fixes an issue that caused an incoming Bridge to not accept any settings changes after re-connecting due to storing references to the already disconnected instances with that same Id.
This should make removal of devices more robust by using the AbortController, however there are still some edge cases there.