Tweaks

SunnySuite · Jan 6, 2025 · fb8f20d · fb8f20d
1 parent d04ece1
commit fb8f20d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/src/KPM/Lanczos.jl b/src/KPM/Lanczos.jl
@@ -51,7 +51,7 @@ function lanczos_ref(A, S, v; niters)
 
     Q = reduce(hcat, vs)
     T = SymTridiagonal(αs, βs)
-    return Q, T
+    return (; Q, T)
 end
 
 

diff --git a/src/KPM/SpinWaveTheoryKPM.jl b/src/KPM/SpinWaveTheoryKPM.jl
@@ -261,9 +261,12 @@ function intensities2!(data, swt_kpm::SpinWaveTheoryKPM, qpts; energies, kernel:
         resolution = (kernel.fwhm/2) / max(-log10(tol), 0)
 
         for ξ in 1:Nobs
+            # Don't accumulate observables that are zero
+            iszero(view(u, :, ξ)) && continue
+
             mulA!(v, view(u, :, ξ))
             mulS!(Sv, v)
-            c = sqrt(Sv' * v)
+            c = sqrt(real(Sv' * v))
             v ./= c
             tridiag, lhs_adj_Q = try
                 lanczos(mulA!, mulS!, v; lhs=u, min_iters=lanczos_iters, resolution, verbose)

diff --git a/src/SpinWaveTheory/HamiltonianDipole.jl b/src/SpinWaveTheory/HamiltonianDipole.jl
@@ -4,7 +4,7 @@ function swt_hamiltonian_dipole!(H::Matrix{ComplexF64}, swt::SpinWaveTheory, q_r
     (; local_rotations, stevens_coefs, sqrtS) = data
     (; extfield, gs) = sys
 
-    L = nbands(swt) 
+    L = nbands(swt)
     @assert size(H) == (2L, 2L)
 
     # Initialize Hamiltonian buffer 

diff --git a/test/test_kpm.jl b/test/test_kpm.jl
@@ -14,7 +14,7 @@
     lhs = randn(N, 2)
     v = randn(N)
     v /= sqrt(dot(v, S, v))
-    Q, T = Sunny.lanczos_ref(A, S, v; niters=10)
+    (; Q, T) = Sunny.lanczos_ref(A, S, v; niters=10)
     ev1 = eigvals(T)
 
     mulA!(w, v) = mul!(w, A, v)