Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add signer keys from datum in v1 #64

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

cjkoepke
Copy link
Member

@cjkoepke cjkoepke commented Oct 3, 2024

Signer keys were assuming that the wallet credentials were the same as the order being cancelled. This caused problems when the person used a multi-address wallet, where they might try cancelling an order using a payment credential that was different than the one used to place the order.

This grabs the real payment and staking credentials from the datum in V1 contracts so that the transaction being built is valid for the contract.

@cjkoepke cjkoepke merged commit f529e95 into main Oct 3, 2024
1 check passed
@cjkoepke cjkoepke deleted the hotfix/correctly-build-cancellations branch October 3, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant