Pr to inquiry v2 #65
Pr to inquiry v2 #65
Conversation
| @@ -58,7 +58,7 @@ export class ViewerService { | |||
| this.isSectionsAvailable = parentConfig?.isSectionsAvailable; | |||
| this.src = config.metadata.artifactUrl || ''; | |||
| this.questionSetId = config.metadata.identifier; | |||
| this.questionSetEvaluable = this.serverValidationCheck(config.metadata?.eval); | |||
| this.questionSetEvaluable = this.serverValidationCheck(config.metadata?.evalMode); | |||
There was a problem hiding this comment.
@pavankumar0408 Can you set the default value of questionSetEvaluable to false instead of type any and in serverValidationCheck method re-assign the value to true based on condition check.
| serverValidationCheck(mode: any) { | ||
| if(mode == 'server') { | ||
| this.questionSetEvaluable = true; | ||
| return this.questionSetEvaluable; |
There was a problem hiding this comment.
@pavankumar0408 Instead of returning the true / false from this method can you just re-assign the value of questionSetEvaluable and use the value in all other places in components. So this way we can reduce the call of same method in multiple places.
| @@ -216,7 +216,7 @@ export class SectionPlayerComponent implements OnChanges, AfterViewInit { | |||
| this.showTimer = this.sectionConfig.metadata?.showTimer; | |||
|
|
|||
| //server-level-validation | |||
| this.questionSetEvaluable = this.viewerService.serverValidationCheck(this.sectionConfig.metadata?.eval); | |||
| this.questionSetEvaluable = this.viewerService.serverValidationCheck(this.sectionConfig.metadata?.evalMode); | |||
There was a problem hiding this comment.
@pavankumar0408 Instead of calling this.viewerService.serverValidationCheck method can you set the value of questionSetEvaluable in viewerService one time and use it like this.viewerService.questionSetEvaluable in all the components
|
|
@rajnishdargan, comments are addressed |
|
Another PR has been raised |
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: