Compass to inquiry pr #60
Conversation
player exam validation changes
…e-platform/player into compass-to-inquiry-pr
Exam validation
…e-platform/player into compass-to-inquiry-pr
…ayer into compass-to-inquiry-pr
|
Added changes for server side evaluation based on eval{mode} property from the questionset. If mode is 'server' test evaluation will happen at server side and if mode is 'client' test evaluation will happen at client side (which is currently existing flow). |
|
@pavankumar0408 If you have the JIRA ticket kindly update the PR title to below format: |
|
@rajnishdargan @sajeshkayyath, required access for adding reviewers |
web-component/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@project-sunbird/sunbird-quml-player-web-component", | |||
| "version": "2.2.0", | |||
| "version": "2.2.0-beta-1", | |||
There was a problem hiding this comment.
@pavankumar0408 Please change it to 3.0.0-beta.0
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -24,7 +24,7 @@ export class QumlLibraryService { | |||
|
|
|||
| constructor(public utilService: UtilService) { } | |||
|
|
|||
| async initializeTelemetry(config: QumlPlayerConfig, parentConfig: IParentConfig) { | |||
| initializeTelemetry(config: QumlPlayerConfig, parentConfig: IParentConfig) { | |||
There was a problem hiding this comment.
@pavankumar0408 Was this async await not needed here?
There was a problem hiding this comment.
Its not required as it is not triggering end event correctly @rajnishdargan
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: