Fix zip traversal vulnerability

Following this proposal solution MobileChromeApps#92 (comment)
SunPower · Feb 10, 2022 · 68725df · 68725df
1 parent 977b57d
commit 68725df
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/android/Zip.java b/src/android/Zip.java
@@ -126,6 +126,14 @@ private void unzipSync(CordovaArgs args, CallbackContext callbackContext) {
                    dir.mkdirs();
                 } else {
                     File file = new File(outputDirectory + compressedName);
+                    String canonicalDestinationPath = (new File(outputDirectory)).getCanonicalPath();
+                    String canonicalPath = file.getCanonicalPath();
+                     if (!canonicalPath.startsWith(canonicalDestinationPath)) {
+                        String errorMessage = "Zip traversal security error";
+                        callbackContext.error(errorMessage);
+                        Log.e(LOG_TAG, errorMessage);
+                        return;
+                    }
                     file.getParentFile().mkdirs();
                     if(file.exists() || file.createNewFile()){
                         Log.w("Zip", "extracting: " + file.getPath());