feat: Add validation for the attributes processor (#1721)

* feat: Add validation for the attributes processor * Add test to validate the attributes processor
SumoLogic · Dec 19, 2024 · b495cd8 · b495cd8
1 parent c36e934
commit b495cd8
Show file tree

Hide file tree

Showing 6 changed files with 52 additions and 0 deletions.
diff --git a/.changelog/1721.added.txt b/.changelog/1721.added.txt
@@ -0,0 +1 @@
+feat: Add validation for the attributes processor
diff --git a/pkg/extension/opampextension/components.go b/pkg/extension/opampextension/components.go
@@ -21,6 +21,7 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/extension/sumologicextension"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor"
@@ -88,6 +89,7 @@ func Components() (
 	errs = multierr.Append(errs, err)
 
 	processors, err := processor.MakeFactoryMap(
+		attributesprocessor.NewFactory(),
 		batchprocessor.NewFactory(),
 		memorylimiterprocessor.NewFactory(),
 		resourcedetectionprocessor.NewFactory(),

diff --git a/pkg/extension/opampextension/go.mod b/pkg/extension/opampextension/go.mod
@@ -17,6 +17,7 @@ require (
 	github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.114.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage v0.114.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/extension/sumologicextension v0.114.0
+	github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.114.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.114.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.114.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.114.0

diff --git a/pkg/extension/opampextension/go.sum b/pkg/extension/opampextension/go.sum
@@ -553,6 +553,8 @@ github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/zipkin
 github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/zipkin v0.114.0/go.mod h1:t5uoTcckI8kQeW1sZl8A+1UebVJPe47Qi3WQeNZu6w4=
 github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.114.0 h1:1xAInvRymxpsuIWz/plGH98eWRhmLVgUHqleBCEeoJM=
 github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.114.0/go.mod h1:3PSKkD/USW8EXij1UTwoRwDFIl0D0V5td9U3n0YEKTo=
+github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.114.0 h1:fltPkjMuiVTtIVwoWUzbL0ad2CTCJsWfnCSDJQ9hSxU=
+github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.114.0/go.mod h1:HcG364Is9u2EDqOUtQX0RwnbHtQqSh5+x2FdcYC+F1M=
 github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.114.0 h1:QBR07Gaw6ePkufQ/AhHgBv4OlwzXlULTdiUnaKIlvLk=
 github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.114.0/go.mod h1:coY0CV/sNj1hltRXKZr2gnrLvr7xUbnW+GhpCQpGR/Y=
 github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.114.0 h1:ttRj/3GIpg+vUTeBI+EBeeWdNuvBT3S/ayoqpvA9B9s=

diff --git a/pkg/extension/opampextension/opamp_agent_test.go b/pkg/extension/opampextension/opamp_agent_test.go
@@ -71,6 +71,7 @@ func TestApplyRemoteConfig(t *testing.T) {
 		{"ApplyKafkaMetricsConfig", "testdata/opamp.d/opamp-kafkametrics-config.yaml", false, ""},
 		{"ApplyElasticsearchConfig", "testdata/opamp.d/opamp-elastic-config.yaml", false, ""},
 		{"ApplyMysqlConfig", "testdata/opamp.d/opamp-mysql-config.yaml", false, ""},
+		{"ApplyattributesprocessorConfig", "testdata/opamp.d/opamp-attributes-processor.yaml", false, ""},
 		{"ApplyPostgresqlConfig", "testdata/opamp.d/opamp-postgresql-config.yaml", false, ""},
 		{"ApplyRabbitmqConfig", "testdata/opamp.d/opamp-rabbitmq-config.yaml", false, ""},
 		{"ApplyRedisConfig", "testdata/opamp.d/opamp-redis-config.yaml", false, ""},

diff --git a/pkg/extension/opampextension/testdata/opamp.d/opamp-attributes-processor.yaml b/pkg/extension/opampextension/testdata/opamp.d/opamp-attributes-processor.yaml
@@ -0,0 +1,45 @@
+receivers:
+  mysql:
+    endpoint: localhost:3306
+    username: otel
+    password: test
+    database: otel
+    collection_interval: 10s
+    initial_delay: 1s
+    statement_events:
+      digest_text_limit: 120
+      time_limit: 24h
+      limit: 250
+exporters:
+    sumologic:
+processors:
+  attributes/example:
+    actions:
+      - key: db.table
+        action: delete
+      - key: redacted_span
+        value: true
+        action: upsert
+      - key: copy_key
+        from_attribute: key_original
+        action: update
+      - key: account_id
+        value: 2245
+        action: insert
+      - key: account_password
+        action: delete
+      - key: account_email
+        action: hash
+      - key: http.status_code
+        action: convert
+        converted_type: int
+
+service:
+  pipelines:
+    metrics/mysql/09c98ea4-6686-4ab9-b3cd-f04070906441:
+      processors:
+        - attributes/example
+      receivers:
+        - mysql
+      exporters:
+        - sumologic
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		feat: Add validation for the attributes processor