SUIT-8895 Fixed unit tests for testLauncher/index.test.js. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsockets package. Fixed TypeErrors which occurs due tests running. Fixed displaying device execution results for SuitestLauncher.
|
Just to clarify, nyc coverage fails on windows only when there is a space id dir name. |
givehug
reviewed
Apr 19, 2018
| @@ -77,11 +77,11 @@ class SuitestLauncher { | |||
| // log all devices logs | |||
| Object.keys(devicesLogs).forEach(dId => log.deviceLines(devicesLogs[dId], dId)); | |||
|
|
|||
There was a problem hiding this comment.
This is quite critical fix
givehug
approved these changes
Apr 19, 2018
andriichumak
deleted the
feature/SUIT-8895-update-testlauncher-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated webbsockets package. Fixed TypeErrors which occurs due tests running. Fixed displaying device execution results for SuitestLauncher.
Unfortunately test coverage still fails. It happens because nyc inside himself use "spawn-wrap" which created child procesess, and this library create temporary execution folders in OS user folder ("Ievgen Kozynskyi" in my case) and path, with spaces, to executable file not wrapped in double quotes and by this reasons tests coverage fails in several places.
istanbuljs/nyc#738
istanbuljs/nyc#784