Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REPL #421

Open
wants to merge 2 commits into
base: v2.x
Choose a base branch
from
Open

Fix REPL #421

wants to merge 2 commits into from

Conversation

onlynone
Copy link

No description provided.

@polomsky polomsky requested a review from JeKachan October 18, 2021 09:25
@polomsky
Copy link
Member

Hello @onlynone . Do you still have the issue with the latest released version of JS API (3.0.0)?

@onlynone
Copy link
Author

@polomsky I haven't had an opportunity to try with the new version and likely won't have an opportunity for a while.

@onlynone
Copy link
Author

onlynone commented Feb 25, 2022

@polomsky This is definitely still an issue. In: https://github.com/SuitestAutomation/suitest-js-api/blob/b12e5a6dabd97345ddf5fc03db44b0453d6f3897/typeDefinition/InteractiveCommandChain.d.ts ReplOptions is defined as:

export type ReplOptions = {
    cwd?:string,
    repeater?: string|Function,
    watch?: string|Array<string>,
    ignored?:string
}

But the docs: https://suite.st/docs/suitest-api/repl-debugging/#parameters have cwd, ignored, repeater, vars, and watch as valid keys in the ReplOptions.

@polomsky
Copy link
Member

@JeKachan please check

@polomsky polomsky changed the base branch from master to v2.x December 30, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants