Hotfix/SUIT-16525-additional-log-options #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 20, 2021 17:07
…hen logLevel: silent was resolved
…-js-api into hotfix/SUIT-16525-additional-log-options
JeKachan
reviewed
May 21, 2021
lib/api/webSockets.js
Outdated
| @@ -56,7 +56,8 @@ const webSocketsFactory = (self) => { | |||
| content.type === 'console' && | |||
| content.data[0] !== 'SUITESTIFY: domainMapping' | |||
| ) { | |||
| const {args: data, method: level} = logger.getAppOutput(content.subtype, content.data); | |||
| const {args: data, method: level} = logger.getAppOutput(content.subtype, content.data) | |||
| || {data: undefined, level: undefined}; | |||
There was a problem hiding this comment.
I think u can use here empty object {}
JeKachan
reviewed
May 21, 2021
lib/api/webSockets.js
Outdated
| @@ -76,7 +77,7 @@ const webSocketsFactory = (self) => { | |||
| const requestBody = logItem.request && logItem.request.requestBody; | |||
| const responseBody = logItem.response && logItem.response.responseBody; | |||
|
|
|||
| if (config.logLevel === logLevels.debug) { | |||
| if (config.networkLogs === logLevels.debug || config.logLevel === logLevels.debug) { | |||
There was a problem hiding this comment.
I think that specific log level should override general setting (have more weight). For example if logLevel defined debug, but networkLogs is not debugg (hidden for example) - network logs should not be displayed
@andriichumak what is preferable behavior?
added 2 commits
May 31, 2021 16:41
… Minnor refactoring. Conditions improvement
polomsky
force-pushed
the
master
branch
4 times, most recently
from
a7cd28b to
ebd5e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.