Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old workaround / fix bug in sb.interpolate #98

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

liamgriffiths
Copy link
Contributor

@liamgriffiths liamgriffiths commented Jul 17, 2024

Before using sb.interpolate when the interpolation items were next to each other a prior workaround was not including them into the Future properly.

A simplest example that demonstrates this might be,

const a = new Box({ value: sb.interpolate`${"x"}` });
const res = await substrate.run(a);
console.log(JSON.stringify(res.json, null, 2));

// outputs
{
  "data": {
    "node1_S2ZNfqWT": {
      "value": ""
    }
  }
}

With this patch these odd cases should work properly.

@liamgriffiths liamgriffiths merged commit 00a04b6 into main Jul 17, 2024
2 checks passed
@liamgriffiths liamgriffiths deleted the liam/interpolate-bug branch July 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant