-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterizing Future
types
#93
Open
liamgriffiths
wants to merge
10
commits into
main
Choose a base branch
from
liam/future-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamgriffiths
force-pushed
the
liam/future-types
branch
from
July 10, 2024 15:10
2718170
to
74ad9a0
Compare
kousun12
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love this
…tions (`jq`, `get`, `at`)
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea here is that we'd like to use a parameterized
Future
type instead of more specific instances with associated methods and instead implement additional helpers as functions that are also parameterized by theFuture
types they accept and return.This change would incur some amount of breaking changes, but maintain equivalent functionality with the goal of simplifying code/understandability for future SDK user code.
Future types will be represented as a single
Future
generic typeString Futures no longer implement the
.concat
instance methodThis method was already exported under
sb
and can continue to be used as expected.Object Futures no longer implement the
.get
instance methodThis method will be exported under
sb
(similar to other future methods)sb.jq
helper function accepts non-string type parameters and deprecates type-mapping argumentCode that uses these previous type mappings should be updated.