Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depends option to set edges without future inputs #91

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

liamgriffiths
Copy link
Contributor

@liamgriffiths liamgriffiths commented Jun 24, 2024

When you would like to control the ordering of nodes in the graph, but do not want to connect nodes via future input args we're implementing the depends option on Node to specify what nodes a node depends on.

What this looks like:

      const a = new FooNode({ a: 123 }, { id: "a" });
      const b = new FooNode({ b: 456 }, { id: "b", depends: [a] });
      const c = new FooNode({ c: 789 }, { id: "c", depends: [a, b] });

When we serialize the graph we'll set the edges key in the API JSON that we'll use on the server when scheduling nodes.

@liamgriffiths liamgriffiths merged commit 3a9ef35 into main Jul 9, 2024
2 checks passed
@liamgriffiths liamgriffiths deleted the liam/depends-edges branch July 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant