Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/0.21.5 #18

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Patch/0.21.5 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1356ff5
feat: expose the CP submission batch size
Esadruhn Sep 19, 2022
caeed10
version
Esadruhn Sep 19, 2022
63cbce2
change arg name
Esadruhn Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connectlib/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.21.4"
__version__ = "0.21.5"
6 changes: 6 additions & 0 deletions connectlib/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ def execute_experiment(
clean_models: bool = True,
name: Optional[str] = None,
additional_metadata: Optional[Dict] = None,
task_submission_batch_size: int = 500,
) -> substra.sdk.models.ComputePlan:
"""Run a complete experiment. This will train (on the `train_data_nodes`) and test (on the
`test_data_nodes`) your `algo` with the specified `strategy` `n_rounds` times and return the
Expand Down Expand Up @@ -264,6 +265,9 @@ def execute_experiment(
name (str, Optional): Optional name chosen by the user to identify the compute plan. If None,
the compute plan name is set to the timestamp.
additional_metadata(dict, Optional): Optional dictionary of metadata to be passed to the Connect WebApp.
task_submission_batch_size(int): The compute plan tasks are submitted by batch. The higher the batch size,
the faster the submission, a batch size that is too high makes the submission fail.
Rule of thumb: batch_size = math.floor(120000 / number_of_samples_per_task)

Returns:
ComputePlan: The generated compute plan
Expand Down Expand Up @@ -364,6 +368,8 @@ def execute_experiment(
clean_models=clean_models,
metadata=cp_metadata,
),
auto_batching=True,
batch_size=task_submission_batch_size,
)
logger.info(("The compute plan has been submitted to Connect, its key is {0}.").format(compute_plan.key))
return compute_plan