feat: set the default batch size to 400 to make the compute plan submission faster #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ission faster Signed-off-by: thaisdeboisfosse <[email protected]>
Signed-off-by: thaisdeboisfosse <[email protected]>
Esadruhn
changed the title
Esadruhn
requested review from
jmorel,
inelgnu,
samlesu,
Fabien-GELUS and
louishulot
as code owners
|
size_of_grpc_packet = const_value * number_of_samples_per_task * number_of_tasks_per_batch we get an error with a CP of 451 tasks, 400 data samples per task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch - include the default batch size update from this commit: 4d9233b
into the release 0.29.2
--> Changing it to 400 as we get timeouts with 450
EDIT: the question is actually more complex than that, discussing it in an issue here: #282