chore: raise if several interfaces are found #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
SdgJlbl
approved these changes
Oct 3, 2024
|
/e2e --tests camelyon,substrafl,sdk |
jeandut
reviewed
Oct 7, 2024
| return found_interfaces[0]() # return interface instance | ||
| elif len(found_interfaces) > 1: | ||
| raise exceptions.InvalidInterfaceError( | ||
| f"Multiple interfaces found in module '{module_name}': {found_interfaces}" |
There was a problem hiding this comment.
Change the error message no one knows what interface mean
There was a problem hiding this comment.
"Multiple opener sub-classes defined in the opener.py file, this is not allowed."
There was a problem hiding this comment.
The opener and the different subclasses will appear in module_name and found_interfaces
There was a problem hiding this comment.
I disagree you don't have the info of interface_class which is in this case opener
There was a problem hiding this comment.
Please add at least interface_class to the debug print statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.