fix: save image timeout 2 (#1011)

* fix: add build timeout during task initialisation Signed-off-by: Guilhem Barthés <[email protected]> * chore: increase default value for `builder.saveImageTimeoutSeconds` Signed-off-by: Guilhem Barthés <[email protected]> * fix: increase default value for `builder.saveImageTimeoutSeconds` Signed-off-by: Guilhem Barthés <[email protected]> * fix: add variable to builder Signed-off-by: Guilhem Barthés <[email protected]> * chore: update chart changelog Signed-off-by: Guilhem Barthés <[email protected]> --------- Signed-off-by: Guilhem Barthés <[email protected]>
Substra · Oct 11, 2024 · 034c060 · 034c060
1 parent 2ff1696
commit 034c060
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/charts/substra-backend/CHANGELOG.md b/charts/substra-backend/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Changelog
 
 <!-- towncrier release notes start -->
+## [26.14.1] - 2024-10-11
+
+# Fixed
+
+Save image timeout not set correctly
+
 ## [26.14.0] - 2024-10-09
 
 # Added

diff --git a/charts/substra-backend/Chart.yaml b/charts/substra-backend/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: substra-backend
 home: https://github.com/Substra
-version: 26.14.0
+version: 26.14.1
 appVersion: 0.48.0
 kubeVersion: '>= 1.19.0-0'
 description: Main package for Substra

diff --git a/charts/substra-backend/README.md b/charts/substra-backend/README.md
@@ -255,7 +255,7 @@ See [UPGRADE.md](https://github.com/Substra/substra-backend/blob/main/charts/sub
 | `builder.nodeSelector`                  | Node labels for pod assignment                                                                                                                     | `{}`                      |
 | `builder.tolerations`                   | Toleration labels for pod assignment                                                                                                               | `[]`                      |
 | `builder.affinity`                      | Affinity settings for pod assignment, ignored if `DataSampleStorageInServerMedia` is `true`                                                        | `{}`                      |
-| `builder.saveImageTimeoutSeconds`       | Amount of seconds before restarting the image save as a blob                                                                                       | `60`                      |
+| `builder.saveImageTimeoutSeconds`       | Amount of seconds before restarting the image save as a blob                                                                                       | `180`                     |
 | `builder.persistence.storageClass`      | Specify the _StorageClass_ used to provision the volume. Or the default _StorageClass_ will be used. Set it to `-` to disable dynamic provisioning | `""`                      |
 | `builder.persistence.size`              | The size of the volume.                                                                                                                            | `10Gi`                    |
 | `builder.rbac.create`                   | Create a role and service account for the builder                                                                                                  | `true`                    |

diff --git a/charts/substra-backend/templates/statefulset-builder.yaml b/charts/substra-backend/templates/statefulset-builder.yaml
@@ -200,6 +200,8 @@ spec:
             value: {{ toYaml .Values.builder.kanikoStartup.maxAttempts | quote }}
           - name: BUILDER_KANIKO_STARTUP_PENDING_STATE_WAIT_SECONDS
             value: {{ toYaml .Values.builder.kanikoStartup.checkDelay | quote }}
+          - name: IMAGE_SAVING_TIMEOUT_SECONDS
+            value: {{ .Values.builder.saveImageTimeoutSeconds | quote }}
           - name: IMAGE_BUILD_TIMEOUT
             value: {{ toYaml .Values.builder.timeout | quote }}
         ports:

diff --git a/charts/substra-backend/values.yaml b/charts/substra-backend/values.yaml
@@ -646,7 +646,7 @@ builder:
   affinity: { }
   ## @param builder.saveImageTimeoutSeconds Amount of seconds before restarting the image save as a blob
   #
-  saveImageTimeoutSeconds: 60
+  saveImageTimeoutSeconds: 180
 
 
   persistence: