Honor the local timezone, fix for #369, stop time travel! #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll clean up this for merging ( it's got some old timey conflict weeds ) . .. If there's interest from @Stuk |
|
nevermind the conflict is trivial and can be binned with -X theirs. |
khalednigrou
approved these changes
Mar 5, 2024
khalednigrou
approved these changes
Mar 5, 2024
|
@khalednigrou @Stuk - is there something I need to do to land this? |
|
Just wanted to share interest in this change and +1 this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no convention for timezones in zips, it's incorrect to assume they are utc. This leads to astonishing behaviour where files are unpacked with different timestamps than they were packed with. (and differs form the command line zip)
The change strips out the explicit UTC calls and relies on the environments' locale.
A test case is included that uses posix style TZ to demonstrate the bug and the fix.