Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4: Add Actions CI to test Docker image build #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue 4: Add Actions CI to test Docker image build #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1d1d28
Issue 1: Update to Pravega 0.9.1
derekm Oct 20, 2021
d114e5b
Issue 4: Add Actions CI to test Docker image build
derekm Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: build
on: [pull_request]
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Check out repository code
uses: actions/checkout@v2
- name: Test Docker image build
run: ./scripts/test-build.sh
6 changes: 3 additions & 3 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
### dependencies
logbackVersion=1.2.3
logstashLogbackEncoderVersion=4.11
pravegaCredentialsVersion=0.8.0-38.808ad78-SNAPSHOT
pravegaVersion=0.8.0-2623.279ac21-SNAPSHOT
pravegaCredentialsVersion=0.9.0
pravegaVersion=0.9.1
slf4jApiVersion=1.7.25

# Set below to true when using Pravega in SDP.
includePravegaCredentials=true

### outputs
samplesVersion=0.8.0
samplesVersion=0.9.1
2 changes: 1 addition & 1 deletion scripts/build-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ROOT_DIR=$(dirname $0)/..

export DOCKER_REPOSITORY=${DOCKER_REPOSITORY:-claudiofahey}
# Below should match the Pravega version
export IMAGE_TAG=${IMAGE_TAG:-0.8.0}
export IMAGE_TAG=${IMAGE_TAG:-0.9.1}

: ${DOCKER_REPOSITORY?"You must export DOCKER_REPOSITORY"}
: ${IMAGE_TAG?"You must export IMAGE_TAG"}
Expand Down
6 changes: 6 additions & 0 deletions scripts/test-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#! /bin/bash
set -ex

ROOT_DIR=$(dirname $0)/..

docker build --no-cache -f ${ROOT_DIR}/pravega-tester/Dockerfile ${ROOT_DIR}