Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update scssPHP #41

Open
mindeffects opened this issue Jun 28, 2019 · 3 comments
Open

Please update scssPHP #41

mindeffects opened this issue Jun 28, 2019 · 3 comments

Comments

@mindeffects
Copy link

mindeffects commented Jun 28, 2019

I had constant trouble with Bootstrap4 (and also Foundation6) and the standard scss-files (see also #35). I failed to compile the plain bs/scss/bootstrap.scss and bs/scss/bootstrap-grid.scss. How can that be?

Getting the BS4.3.1 release from GitHub did not work, but getting the sources from the BS4 website itself ("Download source") was a success – but only AFTER I updated scssPHP.

This is what Composer told me:

CLI:/core/components/modxminify/assetic/vendor$ php ./temp/composer.phar outdated
No composer.json in current directory, do you want to use the one at //core/components/modxminify/assetic? [Y,n]? Y
leafo/scssphp   v0.7.5 v0.8.4 scssphp is a compiler for SCSS written in PHP.
mrclay/minify   2.3.3  3.0.3  Minify is a PHP5 app that helps you follow several rules for client-side performance. It combines multiple CSS or Javascript files, removes unnecessary whitespace and comments, and serves them with gzip enc...
psr/log         1.0.2  1.1.0  Common interface for logging libraries
symfony/process v3.4.9 v4.3.2 Symfony Process Component

leafo/scssphp v0.7.5 >> v0.8.4 !!!

AFTER I did the scssPHP update, I could continue with my life.
I did not update the other components because I was to afraid breaking anything and spending even more time on this trivial task.

Could you please check the MODX Minify package to be capeable of getting the job done with the current BS4 and FD6?

Thanks!

@devlanda
Copy link

@mindeffects This extra is not maintained actively that much.
I've updated leafo/scssphp to v0.8.4 as you requested. Could you test it? https://github.com/Sterc/modx-minify/raw/a385d6152025224c605bb343f780fbb58f19e131/_packages/modxminify-1.0.2-pl.transport.zip (not released yet)

@julienstuder
Copy link

Hi @devlanda installed this 1.0.2 version, but i think it would need a new update to latest version :)

@patrickatwsrn
Copy link

Doesn't change a thing for me:

AH01071: Got error 'PHP message: PHP Fatal error: Uncaught Leafo\ScssPhp\Exception\CompilerException: expecting color, null received: /var/www/vhosts/example.de/httpdocs/modx/assets/libs/bootstrap_source/5.1.3/scss/mixins/_table-variants.scss on line 5,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants