Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify process is too zealous - breaks Bootstrap form styling #28

Closed
muzzwood opened this issue Jan 24, 2018 · 3 comments
Closed

Minify process is too zealous - breaks Bootstrap form styling #28

muzzwood opened this issue Jan 24, 2018 · 3 comments

Comments

@muzzwood
Copy link
Contributor

muzzwood commented Jan 24, 2018

Some CSS rules require spaces. For example Bootstrap has the following applied to its input elements: height: calc(2.25rem + 2px). The + requires a space on either side or it doesn't work. Unfortunately the spaces get stripped out leaving the input oddly sized. I've worked around this on my current project by adding inline css to the form but it'd be great to get this fixed properly.

@inreti-sb
Copy link

Had the same issue using Bulma Framework.

@black-meridian
Copy link

I just update the folder /core/components/modxminify/assetic/vendor/leafo/

with the last version of scssphp https://github.com/leafo/scssphp and it's now working

@devlanda
Copy link

I will close this issue. Please see #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants