This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Bugfix/issue 36 #57
Open
Bugfix/issue 36 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in strings matching any part of ''<span class="simplesearch-highlight">...</span>'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue #36
The code fix addresses that search terms are highlighted by tag and class.
If search string contains several segments, each segment is enclosed with element to highlight it.
Issue is that if search segment matches any part of highlighting tag, it will be enclosed with highlight tag again.
for example:
Search string is "De las"
The highlighting would work like:
Pass 1: Match "De" in "De las" and replace. The result is "De las"
Pass 2: Match "les" in "<span class='simplesearch-highlight'>De las" and replace. The result is:
<span c<span class='simplesearch-highlight'>las</span>s='simplesearch-highlight'>De</span> lasThe fix is to highlight each segment of search string separately and then concatenate all segments back to string.