Help with plugin chaining #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a field to select yes/no to triggering the FileSluggyOnUpdateFilename event even if a rename wasn't required
Adds a field to select yes/no to triggering the FileSluggyOnUpdateFilename event even if a rename wasn't required
…t required Adds additional $files, $source and $directory arrays to the FileSluggyOnUpdateFilename hook and optionally, based on system setting, runs it even if a rename isn't required so that another plugin can run reliably based on its results.
Code to trigger event for norename was in the wrong spot in the chain of logic
Rename the previously added filesluggy.triggerFSOUFEventOnNoRename event to filesluggy.forceFSOUFEvent
Rename the previously added filesluggy.triggerFSOUFEventOnNoRename setting to filesluggy.forceFSOUFEvent
Rename the previously created filesluggy.triggerFSOUFEventOnNoRename to filesluggy.forceFSOUFEvent
|
Just reapplied these fixes to keep the latest version working. +1 vote (do I get a second vote 2+ years on? 😅) to have these changes integrated into the base to allow people to chain things to treat uploads following FileSluggy sanitisation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, it's difficult to do anything with the result of a FileSluggy rename. Only the old and new file names are passed to the FileSluggyOnUpdateFileName event whereas to have something work on the files, it'll also want the media source, upload directory and the other details stored in the $files variable.
This update adds those to the event trigger as well as adding a system-setting to allow the user to force the FileSluggyOnUpdateFileName event to be triggered with the original file upload information in the event that a rename wasn't actually required.
Doing it this way allows plugins to 'hitch their wagon' to the event REGARDLESS of whether a file rename took place. The alternative would be to trigger on both the FileSluggyOnUpdateFileName event AS WELL AS the OnFileManagerUpload event, knowing that one or the other was going to find its target file missing and be the wrong code to run.
Would require insertion of new 'nl' lexicon items - I've only added the English as it's all I know.