[Bug] Fix the incorrect lookup join result when lookup from level0 (a…

…pache#2913)
Stephen0421 · Feb 27, 2024 · f6c8c46 · f6c8c46
1 parent ece4f84
commit f6c8c46
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 5 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/mergetree/LookupUtils.java b/paimon-core/src/main/java/org/apache/paimon/mergetree/LookupUtils.java
@@ -39,14 +39,15 @@ public static <T> T lookup(
             BiFunctionWithIOE<InternalRow, SortedRun, T> lookup,
             BiFunctionWithIOE<InternalRow, TreeSet<DataFileMeta>, T> level0Lookup)
             throws IOException {
-        if (startLevel == 0) {
-            return level0Lookup.apply(key, levels.level0());
-        }
 
         T result = null;
         for (int i = startLevel; i < levels.numberOfLevels(); i++) {
-            SortedRun level = levels.runOfLevel(i);
-            result = lookup.apply(key, level);
+            if (i == 0) {
+                result = level0Lookup.apply(key, levels.level0());
+            } else {
+                SortedRun level = levels.runOfLevel(i);
+                result = lookup.apply(key, level);
+            }
             if (result != null) {
                 break;
             }

diff --git a/paimon-core/src/test/java/org/apache/paimon/mergetree/LookupLevelsTest.java b/paimon-core/src/test/java/org/apache/paimon/mergetree/LookupLevelsTest.java
@@ -215,6 +215,41 @@ public void testLookupEmptyLevel() throws IOException {
         assertThat(kv).isNotNull();
     }
 
+    @Test
+    public void testLookupLevel0() throws Exception {
+        Levels levels =
+                new Levels(
+                        comparator,
+                        Arrays.asList(
+                                newFile(0, kv(1, 0)),
+                                newFile(1, kv(1, 11), kv(3, 33), kv(5, 5)),
+                                newFile(2, kv(2, 22), kv(5, 55))),
+                        3);
+        LookupLevels lookupLevels = createLookupLevels(levels, MemorySize.ofMebiBytes(10));
+
+        KeyValue kv = lookupLevels.lookup(row(1), 0);
+        assertThat(kv).isNotNull();
+        assertThat(kv.sequenceNumber()).isEqualTo(UNKNOWN_SEQUENCE);
+        assertThat(kv.level()).isEqualTo(0);
+        assertThat(kv.value().getInt(1)).isEqualTo(0);
+
+        levels =
+                new Levels(
+                        comparator,
+                        Arrays.asList(
+                                newFile(1, kv(1, 11), kv(3, 33), kv(5, 5)),
+                                newFile(2, kv(2, 22), kv(5, 55))),
+                        3);
+        lookupLevels = createLookupLevels(levels, MemorySize.ofMebiBytes(10));
+
+        // not in level 0
+        kv = lookupLevels.lookup(row(1), 0);
+        assertThat(kv).isNotNull();
+        assertThat(kv.sequenceNumber()).isEqualTo(UNKNOWN_SEQUENCE);
+        assertThat(kv.level()).isEqualTo(1);
+        assertThat(kv.value().getInt(1)).isEqualTo(11);
+    }
+
     private LookupLevels createLookupLevels(Levels levels, MemorySize maxDiskSize) {
         return new LookupLevels(
                 levels,